Skip to content

Commit 6d7ff51

Browse files
author
Claire Carroll
authored
Merge pull request #319 from fishtown-analytics/0-19-0-updates
broken commit: update internals of insert by period
2 parents d91c386 + 46dbfed commit 6d7ff51

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

macros/materializations/insert_by_period_materialization.sql

+8-2
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,13 @@
142142
from {{tmp_relation.include(schema=False)}}
143143
);
144144
{%- endcall %}
145-
{%- set rows_inserted = (load_result('main-' ~ i)['status'].split(" "))[2] | int -%}
145+
{% set result = load_result('main-' ~ i) %}
146+
{% if 'response' in result.keys() %} {# added in v0.19.0 #}
147+
{% set rows_inserted = result['response']['rows_affected'] %}
148+
{% else %} {# older versions #}
149+
{% set rows_inserted = result['status'].split(" ")[2] | int %}
150+
{% endif %}
151+
146152
{%- set sum_rows_inserted = loop_vars['sum_rows_inserted'] + rows_inserted -%}
147153
{%- if loop_vars.update({'sum_rows_inserted': sum_rows_inserted}) %} {% endif -%}
148154

@@ -165,7 +171,7 @@
165171

166172
{%- set status_string = "INSERT " ~ loop_vars['sum_rows_inserted'] -%}
167173

168-
{% call noop_statement(name='main', status=status_string) -%}
174+
{% call noop_statement('main', status_string) -%}
169175
-- no-op
170176
{%- endcall %}
171177

run_test.sh

+3
Original file line numberDiff line numberDiff line change
@@ -24,5 +24,8 @@ if [[ ! -z $3 ]]; then _seeds="--select $3 --full-refresh"; fi
2424

2525
dbt deps --target $1
2626
dbt seed --target $1 $_seeds
27+
if [ $1 == 'redshift' ]; then
28+
dbt run -x -m test_insert_by_period --full-refresh --target redshift
29+
fi
2730
dbt run -x --target $1 $_models
2831
dbt test -x --target $1 $_models

0 commit comments

Comments
 (0)