Skip to content

Commit 46dbfed

Browse files
author
Claire Carroll
authored
Merge pull request #320 from fishtown-analytics/fix/insert-by-period-0-19
Fix: insert by period for 0.19
2 parents 3e0e691 + 8e06246 commit 46dbfed

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

macros/materializations/insert_by_period_materialization.sql

+6-2
Original file line numberDiff line numberDiff line change
@@ -143,8 +143,12 @@
143143
);
144144
{%- endcall %}
145145
{% set result = load_result('main-' ~ i) %}
146-
{% set rows_inserted = result['response']['rows_affected'] %}
146+
{% if 'response' in result.keys() %} {# added in v0.19.0 #}
147+
{% set rows_inserted = result['response']['rows_affected'] %}
148+
{% else %} {# older versions #}
149+
{% set rows_inserted = result['status'].split(" ")[2] | int %}
147150
{% endif %}
151+
148152
{%- set sum_rows_inserted = loop_vars['sum_rows_inserted'] + rows_inserted -%}
149153
{%- if loop_vars.update({'sum_rows_inserted': sum_rows_inserted}) %} {% endif -%}
150154

@@ -167,7 +171,7 @@
167171

168172
{%- set status_string = "INSERT " ~ loop_vars['sum_rows_inserted'] -%}
169173

170-
{% call noop_statement(name='main', message=status_string) -%}
174+
{% call noop_statement('main', status_string) -%}
171175
-- no-op
172176
{%- endcall %}
173177

run_test.sh

+3
Original file line numberDiff line numberDiff line change
@@ -24,5 +24,8 @@ if [[ ! -z $3 ]]; then _seeds="--select $3 --full-refresh"; fi
2424

2525
dbt deps --target $1
2626
dbt seed --target $1 $_seeds
27+
if [ $1 == 'redshift' ]; then
28+
dbt run -x -m test_insert_by_period --full-refresh --target redshift
29+
fi
2730
dbt run -x --target $1 $_models
2831
dbt test -x --target $1 $_models

0 commit comments

Comments
 (0)