Skip to content
This repository was archived by the owner on Dec 4, 2024. It is now read-only.

dbt utils v1 compatibility #55

Merged
merged 3 commits into from
Dec 6, 2022
Merged

dbt utils v1 compatibility #55

merged 3 commits into from
Dec 6, 2022

Conversation

joellabes
Copy link
Contributor

Description & motivation

A final release with compatibility with v1 of dbt utils

Checklist

  • I have verified that these changes work locally
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)

@joellabes joellabes requested a review from dbeatty10 December 2, 2022 08:05
Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (assuming CI passes when targeting dbt-utils 1.0.0-rc1)

@joellabes
Copy link
Contributor Author

@dbeatty10 they all pass under rc1, but not at the same time. As far as I can see, this is an oddity to do with the run-operation step that cleans up the schema between tests 1 and 2. Since they run in isolation, and this is going to be the final release anyway, I'm willing to just call it a win and not spend too much time digging into why. lmk if you disagree?

@joellabes joellabes merged commit 9828dac into main Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants