Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite loop #873

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Conversation

zsoerenm
Copy link
Contributor

Fixes #871
slotParentNode is always the same parentNode:

const slotParentNode = el?.assignedSlot?.parentNode;

Therefore, target for next round doesn't change. This ends in an infinite loop.
I'm unsure what the purpose of

const parentNode = slotParentNode || targetParentNode;

was.
Setting

const parentNode = targetParentNode;

works in my case, but I'm unsure, if it breaks others code.

@daybrush daybrush merged commit 179f950 into daybrush:master Mar 21, 2023
@daybrush
Copy link
Owner

@zsoerenm

lit-movaeble's new version is released. Thank you for PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite loop when using infinite viewer and moveable together. Browser becomes unresponsive.
2 participants