Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Roundable control not always initializing #756

Closed
SidIcarus opened this issue Oct 5, 2022 · 3 comments
Closed

Bug: Roundable control not always initializing #756

SidIcarus opened this issue Oct 5, 2022 · 3 comments
Labels
bug Something isn't working complete
Milestone

Comments

@SidIcarus
Copy link

Environments

  • Framework name: VanillaJS
  • Moveable Component version: 0.36.3
  • Testable Address(optional): Codepen

Description

Roundable control does not initialize on start or on edge double click.

I've gotten it to work on my local project somehow but when I try to use CSS variables to set the border radius, it ends up doing what we see in the linked codepen.
If i update the CSS after initialization, it works with the css variable. But if the control is removed, clicking to create doesn't work.

@SidIcarus SidIcarus changed the title Regression Bug: Roundable not always Bug: Roundable not always Oct 5, 2022
@SidIcarus SidIcarus changed the title Bug: Roundable not always Bug: Roundable control not always initializing Oct 5, 2022
@SidIcarus
Copy link
Author

Issue seems to also be present in the first storybook

@daybrush daybrush added the bug Something isn't working label Oct 10, 2022
daybrush added a commit that referenced this issue Oct 10, 2022
@daybrush daybrush added this to the 0.36.3 milestone Oct 10, 2022
@daybrush
Copy link
Owner

@SidIcarus

  • @moveable/helper 0.0.4
  • lit-moveable 0.13.4
  • moveable 0.36.4
  • preact-moveable 0.38.4
  • react-compat-moveable 0.24.4
  • react-moveable 0.39.4
  • svelte-moveable 0.28.4
  • vue-moveable 2.0.0-beta.41
  • vue3-moveable 0.11.4
  • ngx-moveable 0.33.4

moveable's new version is released. Check it again.

In the future, the position/action of the roundable's control button will be changed more easily.

@SidIcarus
Copy link
Author

SidIcarus commented Oct 10, 2022

It also seems that effects of edge: true prevents roundClickable: true from working.

@daybrush
I will close out this issue and post another one dedicated to this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working complete
Projects
None yet
Development

No branches or pull requests

2 participants