Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrollable not working #150

Closed
ladifire opened this issue Jan 8, 2020 · 5 comments
Closed

Scrollable not working #150

ladifire opened this issue Jan 8, 2020 · 5 comments
Labels
bug Something isn't working complete question Further information is requested React
Milestone
0.13.4

Comments

@ladifire
Copy link

ladifire commented Jan 8, 2020

@daybrush How can use scrollable?
See this demo, scrollable not working as expect.https://codesandbox.io/s/react-moveable-demo-cudj3
@daybrush
Copy link
Owner

daybrush commented Jan 9, 2020

@ladifire

Use onScroll event and the scrollContainer should use document.documentElement instead of document.body.
https://codesandbox.io/s/react-moveable-demo-h5039

@daybrush daybrush added question Further information is requested React labels Jan 9, 2020
@ladifire
Copy link
Author

ladifire commented Jan 9, 2020

@daybrush It can scroll, but position is wrong when you scroll and drag

@ladifire
Copy link
Author

ladifire commented Jan 9, 2020

Just want drag position should be updated when hold drag and scroll. the same to resize, rotate

@daybrush daybrush added the bug Something isn't working label Jan 9, 2020
@daybrush
Copy link
Owner

daybrush commented Jan 9, 2020

@ladifire

I think I should check. Only drag is supported, not resize and rotate.

@daybrush daybrush added this to the 0.13.4 milestone Jan 9, 2020
daybrush added a commit that referenced this issue Jan 9, 2020
@daybrush
fix: fix scrollable's position #150
7ef034e
daybrush added a commit that referenced this issue Jan 11, 2020
@daybrush
fix: fix scrollable's wrong position #150
d4ddb41
@daybrush
Copy link
Owner

@ladifire

A new version has been released.

  • moveable 0.13.4
  • react-moveable 0.16.6
  • preact-moveable 0.15.5
  • ngx-moveable 0.9.4
  • svelte-moveable 0.4.4

Update to the new version. Thank you :)

@daybrush daybrush closed this as completed Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working complete question Further information is requested React
Projects
None yet
Milestone
0.13.4
Development

No branches or pull requests
2 participants
@daybrush @ladifire