Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to display snap distance when drag? #142

Closed
ladifire opened this issue Jan 3, 2020 · 6 comments
Closed

How to display snap distance when drag? #142

ladifire opened this issue Jan 3, 2020 · 6 comments
Labels
complete Feature
Milestone
0.15.0

Comments

@ladifire
Copy link

ladifire commented Jan 3, 2020 •
edited
Loading

Please tell me how to display snap distance as following photo:
Screenshot from 2020-01-03 16-48-08

Where: sfs is distance (px)
@daybrush
Copy link
Owner

daybrush commented Jan 6, 2020

@ladifire

It doesn't provide the following features yet.

I will add this feature in a future version.

@daybrush daybrush added this to the 0.14.0 milestone Jan 6, 2020
@ladifire
Copy link
Author

ladifire commented Jan 6, 2020

Thanks you!

@ladifire ladifire closed this as completed Jan 6, 2020
@daybrush daybrush reopened this Jan 13, 2020
@daybrush daybrush modified the milestones: 0.14.0, 0.13.5 Jan 30, 2020
daybrush added a commit that referenced this issue Feb 2, 2020
@daybrush
feat: Support display snap distance #142
5f514c4
@daybrush
Copy link
Owner

daybrush commented Feb 2, 2020

@ladifire

Moveable 0.14.0 is released. Thank you :)

  • moveable 0.14.0
  • react-moveable 0.17.0
  • preact-moveable 0.16.0
  • ngx-moveable 0.10.0
  • svelte-moveable 0.5.0

@ladifire
Copy link
Author

ladifire commented Feb 3, 2020 •
edited
Loading

@daybrush
I think the decimal number for snap distance is not necessary, you should round it up.
And one more problem:

See this demo: https://codesandbox.io/s/react-moveable-with-full-drag-select-wb0so and try drag "test_33" element.

When there's at least one SAME size element with DRAGGING ELEMENT, snap display 3 snap lines. This is not necessary.

Thanks you!

daybrush added a commit that referenced this issue Feb 4, 2020
@daybrush
fix: remove duplicate snap size display #142
cfae79e
@daybrush
Copy link
Owner

daybrush commented Feb 4, 2020

@ladifire
I will remove duplicate snap size display and add snapDigit props

daybrush added a commit that referenced this issue Feb 4, 2020
@daybrush
feat: Add snapDigit props #142
c607926
@daybrush daybrush modified the milestones: 0.14.0, 0.15.0 Feb 4, 2020
@daybrush daybrush added WIP and removed complete labels Feb 11, 2020
@daybrush daybrush mentioned this issue Feb 11, 2020
Merged
daybrush added a commit that referenced this issue Feb 20, 2020
@daybrush
refactor: fix for size snap and resize for [0, 0] #141 #142 #172 #173 (…
9e76437 
…#177)

#141 #142 #172 #173 #179
* fix: fix snap directions

* fix: fix sizeDist for otherDirections

* refactor: fix resizable snap

* refactor: remove checkOneWayDist

* refactor: fix one way resize snap

* refactor: fix snap resize for keepRatio

* refactor: snap resize for [0, 0]

* fix: fix two way direction

* feat: add requestSigns

* fix: fix request snap

* fix: fix request for no request

* fix: fix resize snap for request

* fix: fix snap for scale

* fix: fix size snap for shake problem

* feat: add isDisplaySnapDigit props

* fix: fix package script

* feat: add innerBounds props #172

* feat: add innerBounds feature #172

* feat: add innerBounds feature #172

* fix: fix innerBounds' direction

* fix: fix innerBounds' size offset

* fix: fix bounds for fixed position

* fix: fix parseFloat

* feat: add innerBounds for drag

* feat: add innerBound drag snap

* fix: fix fixedPosition

* refactor: split snappable

* fix: fix innerBound for drag

* fix: fix throttleRotateDrag's work

* fix: fix snapInfo to snapDrag

* refactor: fix snapRotate

* fix: fix throttleRotateDrag snap

* fix: fix rotatable delta

* fix: fix rotatable for innerBounds

* feat: show innerBounds guidelines

* fix: remove useless code
@daybrush daybrush added WIP-complete and removed WIP labels Feb 20, 2020
@daybrush
Copy link
Owner

daybrush commented Mar 4, 2020

@ladifire

  • moveable 0.15.1
  • react-moveable 0.18.0
  • preact-moveable 0.17.0
  • ngx-moveable 0.11.0
  • svelte-moveable 0.6.0

Use snapDigit. (now default is 0) (previous 4)

https://daybrush.com/moveable/release/latest/doc/Moveable.html#snapDigit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
complete Feature
Projects
None yet
Milestone
0.15.0
Development

No branches or pull requests
2 participants
@daybrush @ladifire