Small refactoring: extract validate_enum and validate_const methods

[beetlegius-jt]

In order to be able to override how we're validating enums and const we need to first extract it as separate methods, so we're able to take advantage of the inheritance and override that small methods.

This won't affect the current codebase but will allow us to start working on supporting draft 2020-12 based on that.

[davishmcclurg]

Can you point me to what changed for these keywords (enum and const) in the new drafts? It doesn't look like they've changed to me, but I could be missing something (looking here: https://json-schema.org/draft/2020-12/json-schema-validation.html#name-enum).

[davishmcclurg]

I think we should pass enum to this method instead:

validate_enum(instance, enum, &block) if enum

[davishmcclurg]

Same here. And you could pull out const above (similar to enum on line 87):

validate_const(instance, const, &block) if schema.key?('const')

[beetlegius-jt]

Can you point me to what changed for these keywords (enum and const) in the new drafts? It doesn't look like they've changed to me, but I could be missing something (looking here: https://json-schema.org/draft/2020-12/json-schema-validation.html#name-enum).

Sure, there is a new nullable boolean property, so you can mark the enum as nullable and it should skip the validation because it accepts null.

Old

language:
  oneOf:
    - type: string
      enum:
        - ruby
        - python
    - type: null

New

type: string
enum:
  - ruby
  - python
nullable: true

[davishmcclurg]

Sure, there is a new nullable boolean property, so you can mark the enum as nullable and it should skip the validation because it accepts null.

I don't see nullable in draft 2020-12 either. Looks like it might have been an OpenAPI feature that they removed?
json-schema-org/json-schema-spec#1067
OAI/OpenAPI-Specification#2246

[ahx]

Looks like it might have been an OpenAPI feature that they removed?

That is correct. It was removed in OpenAPI 3.1, because you can just use multiple types.

[beetlegius-jt]

Closing then people! Thanks