Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix intersection with zero area rectangles #92

Merged
merged 6 commits into from
Jun 26, 2019

Conversation

davidmoten
Copy link
Owner

See discussion in #91.

I've started with rectangleIntersectsLine. Might have to check rectangle intersects rectangle case too.

@codecov-io
Copy link

codecov-io commented Jun 26, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@6798826). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #92   +/-   ##
=========================================
  Coverage          ?   75.68%           
  Complexity        ?      833           
=========================================
  Files             ?       72           
  Lines             ?     2344           
  Branches          ?      316           
=========================================
  Hits              ?     1774           
  Misses            ?      478           
  Partials          ?       92
Impacted Files Coverage Δ Complexity Δ
...ithub/davidmoten/rtree/internal/RectangleUtil.java 59.61% <100%> (ø) 21 <3> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6798826...fed4e01. Read the comment docs.

@davidmoten
Copy link
Owner Author

Build is actually fine, will sort travis stuff out later.

I don't think further action is required on this PR so I'm going to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants