Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more DT/EM/section constants #70

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Add more DT/EM/section constants #70

merged 1 commit into from
Oct 13, 2022

Conversation

Bo98
Copy link
Contributor

@Bo98 Bo98 commented Oct 11, 2022

These are largely from binutils.

@Bo98 Bo98 mentioned this pull request Oct 11, 2022
Merged
@Bo98 Bo98 force-pushed the constants-update branch from 63e0d32 to ab8973f Compare October 12, 2022 16:20
@Bo98
Copy link
Contributor Author

Bo98 commented Oct 12, 2022 

lib/elftools/constants.rb:54:5: C: Metrics/ModuleLength: Module has too many lines. [122/100]
   module DT ...
   ^^^^^^^^^

I don't think I can really fix that given it's an enumeration module, so I've added the file as an exclusion if that's ok.

@david942j
Copy link
Owner 

lib/elftools/constants.rb:54:5: C: Metrics/ModuleLength: Module has too many lines. [122/100]
   module DT ...
   ^^^^^^^^^

I don't think I can really fix that given it's an enumeration module, so I've added the file as an exclusion if that's ok.

sounds good to me

david942j
david942j reviewed Oct 13, 2022
View reviewed changes
@david942j david942j changed the title Add missing constants Add more DT/EM/section constants Oct 13, 2022
@david942j david942j merged commit f81a388 into david942j:master Oct 13, 2022
@david942j
Copy link
Owner

Merged. Thanks for the contribution!

@Bo98 Bo98 deleted the constants-update branch October 13, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david942j david942j david942j left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bo98 @david942j