david942j · david942j · Jul 3, 2019 · Jul 3, 2019
diff --git a/elftools.gemspec b/elftools.gemspec
@@ -1,8 +1,10 @@
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'elftools/version'
+
 require 'date'
 
+require 'elftools/version'
+
 Gem::Specification.new do |s|
   s.name        = 'elftools'
   s.version     = ::ELFTools::VERSION
@@ -17,14 +19,14 @@ Gem::Specification.new do |s|
   s.files       = Dir['lib/**/*.rb'] + %w(README.md)
   s.homepage    = 'https://github.com/david942j/rbelftools'
   s.license     = 'MIT'
-  s.required_ruby_version = '>= 2.1.0'
+  s.required_ruby_version = '>= 2.3'
 
   s.add_runtime_dependency 'bindata', '~> 2'
 
   s.add_development_dependency 'pry', '~> 0.10'
   s.add_development_dependency 'rake', '~> 12.1'
   s.add_development_dependency 'rspec', '~> 3.7'
   s.add_development_dependency 'rubocop', '~> 0.59'
-  s.add_development_dependency 'simplecov', '~> 0.16.1'
+  s.add_development_dependency 'simplecov', '~> 0.17'
   s.add_development_dependency 'yard', '~> 0.9'
 end
diff --git a/lib/elftools.rb b/lib/elftools.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'elftools/constants'
 require 'elftools/elf_file'
 require 'elftools/version'

diff --git a/lib/elftools/constants.rb b/lib/elftools/constants.rb
@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 module ELFTools
   # Define constants from elf.h.
   # Mostly refer from https://github.com/torvalds/linux/blob/master/include/uapi/linux/elf.h
   # and binutils/elfcpp/elfcpp.h.
   module Constants
     # ELF magic header
-    ELFMAG = "\x7FELF".freeze
+    ELFMAG = "\x7FELF"
 
     # Values of `d_un.d_val' in the DT_FLAGS and DT_FLAGS_1 entry.
     module DF

diff --git a/lib/elftools/dynamic.rb b/lib/elftools/dynamic.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ELFTools
   # Define common methods for dynamic sections and dynamic segments.
   #
@@ -89,7 +91,7 @@ def tags_by_type(type)
     # @param [Integer] n The index.
     # @return [ELFTools::Dynamic::Tag] The desired tag.
     def tag_at(n)
-      return if n < 0
+      return if n.negative?
 
       @tag_at_map ||= {}
       return @tag_at_map[n] if @tag_at_map[n]

diff --git a/lib/elftools/elf_file.rb b/lib/elftools/elf_file.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'elftools/constants'
 require 'elftools/exceptions'
 require 'elftools/lazy_array'

diff --git a/lib/elftools/exceptions.rb b/lib/elftools/exceptions.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ELFTools
   # Being raised when parsing error.
   class ELFError < StandardError; end

diff --git a/lib/elftools/lazy_array.rb b/lib/elftools/lazy_array.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ELFTools
   # A helper class for {ELFTools} easy to implement
   # 'lazy loading' objects.
@@ -37,7 +39,7 @@ def initialize(size, &block)
     #   return type of block given in {#initialize}.
     def [](i)
       # XXX: support negative index?
-      return nil if i < 0 || i >= @internal.size
+      return nil unless i.between?(0, @internal.size - 1)
 
       @internal[i] ||= @block.call(i)
     end

diff --git a/lib/elftools/note.rb b/lib/elftools/note.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'elftools/structs'
 require 'elftools/util'
 

diff --git a/lib/elftools/sections/dynamic_section.rb b/lib/elftools/sections/dynamic_section.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'elftools/dynamic'
 require 'elftools/sections/section'
 

diff --git a/lib/elftools/sections/note_section.rb b/lib/elftools/sections/note_section.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'elftools/note'
 require 'elftools/sections/section'
 

diff --git a/lib/elftools/sections/null_section.rb b/lib/elftools/sections/null_section.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'elftools/sections/section'
 
 module ELFTools

diff --git a/lib/elftools/sections/relocation_section.rb b/lib/elftools/sections/relocation_section.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'elftools/constants'
 require 'elftools/sections/section'
 require 'elftools/structs'

diff --git a/lib/elftools/sections/section.rb b/lib/elftools/sections/section.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'elftools/constants'
 module ELFTools
   module Sections

diff --git a/lib/elftools/sections/sections.rb b/lib/elftools/sections/sections.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Require this file to load all sections classes.
 
 require 'elftools/sections/section'

diff --git a/lib/elftools/sections/str_tab_section.rb b/lib/elftools/sections/str_tab_section.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'elftools/sections/section'
 require 'elftools/util'
 

diff --git a/lib/elftools/sections/sym_tab_section.rb b/lib/elftools/sections/sym_tab_section.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'elftools/sections/section'
 
 module ELFTools

diff --git a/lib/elftools/segments/dynamic_segment.rb b/lib/elftools/segments/dynamic_segment.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'elftools/segments/segment'
 require 'elftools/dynamic'
 

diff --git a/lib/elftools/segments/interp_segment.rb b/lib/elftools/segments/interp_segment.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'elftools/segments/segment'
 
 module ELFTools

diff --git a/lib/elftools/segments/load_segment.rb b/lib/elftools/segments/load_segment.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'elftools/segments/segment'
 
 module ELFTools

diff --git a/lib/elftools/segments/note_segment.rb b/lib/elftools/segments/note_segment.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'elftools/note'
 require 'elftools/segments/segment'
 

diff --git a/lib/elftools/segments/segment.rb b/lib/elftools/segments/segment.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ELFTools
   module Segments
     # Base class of segments.

diff --git a/lib/elftools/segments/segments.rb b/lib/elftools/segments/segments.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Require this file to load all segment classes.
 
 require 'elftools/segments/segment'

diff --git a/lib/elftools/structs.rb b/lib/elftools/structs.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bindata'
 module ELFTools
   # Define ELF related structures in this module.

diff --git a/lib/elftools/util.rb b/lib/elftools/util.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ELFTools
   # Define some util methods.
   module Util

diff --git a/lib/elftools/version.rb b/lib/elftools/version.rb
@@ -1,4 +1,6 @@
+# frozen_string_literal: true
+
 module ELFTools
   # Current gem version
-  VERSION = '1.1.0'.freeze
+  VERSION = '1.1.0'
 end
diff --git a/spec/constants_spec.rb b/spec/constants_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'elftools/constants'
 
 describe ELFTools::Constants do

diff --git a/spec/dynamic_spec.rb b/spec/dynamic_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'elftools/elf_file'
 
 describe ELFTools::Dynamic do

diff --git a/spec/elf_file_spec.rb b/spec/elf_file_spec.rb
@@ -1,4 +1,5 @@
 # encoding: ascii-8bit
+# frozen_string_literal: true
 
 require 'tempfile'
 

diff --git a/spec/full_test/i386_spec.rb b/spec/full_test/i386_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'elftools'
 
 describe 'Full test for i386' do

diff --git a/spec/full_test/pie_spec.rb b/spec/full_test/pie_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'elftools'
 
 describe 'Full test for PIE' do

diff --git a/spec/full_test/relro_spec.rb b/spec/full_test/relro_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'elftools'
 
 describe 'Full test for relro types' do

diff --git a/spec/full_test/so_spec.rb b/spec/full_test/so_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'elftools'
 
 describe 'Full test for shared object' do

diff --git a/spec/full_test/striped_spec.rb b/spec/full_test/striped_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'elftools'
 
 describe 'Full test for striped binary' do

diff --git a/spec/sections_spec.rb b/spec/sections_spec.rb
@@ -1,4 +1,5 @@
 # encoding: ascii-8bit
+# frozen_string_literal: true
 
 require 'elftools/sections/sections'
 require 'elftools/structs'

diff --git a/spec/segments_spec.rb b/spec/segments_spec.rb
@@ -1,4 +1,5 @@
 # encoding: ascii-8bit
+# frozen_string_literal: true
 
 require 'elftools/segments/segments'
 require 'elftools/structs'

diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'simplecov'
 SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter.new(
   [SimpleCov::Formatter::HTMLFormatter]

diff --git a/spec/util_spec.rb b/spec/util_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'elftools/util'
 
 describe ELFTools::Util do