-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pydantic v2 #67
Pydantic v2 #67
Conversation
Codecov Report
@@ Coverage Diff @@
## main #67 +/- ##
==========================================
- Coverage 95.42% 95.31% -0.12%
==========================================
Files 28 28
Lines 1531 1537 +6
==========================================
+ Hits 1461 1465 +4
- Misses 70 72 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
It looks great! I also like the overall improvements!
Some small questions and comments here and there. I can also take this up later if you'd like
All good, very glad - I am not too busy nowadays either way still, and it's fun to contribute to actual OSS for the first time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good! Thanks again for your time and effort!
I'd just look into the __eq__
and aside from that I think we're good to go!
Looked at it. Had to dig very deep, but in essence, bumped Pydantic even more, and there was no need to keep any custom Ready for review again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome! Just one very small change - pedantry really
I can also make these small changes - but it'll be a bit later
Updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks a lot!
Big improvements!!
🤝 |
As requested in the issue, PR migrates the codebase to PydanticV2. PydanticV2 introduces a plethora of performance optimisations (e.g. by being Rust-backed for validations), and some APIs (like root models can wrap Python types now) have been refined.
Changes:
__root__
field got changed toroot
.TODO: