Skip to content

Commit

Permalink
Merge pull request #53 from datarootsio/relax-typer-version
Browse files Browse the repository at this point in the history
Relax typer version
  • Loading branch information
murilo-cunha authored Nov 5, 2022
2 parents a7ead55 + a83120f commit 020958b
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 12 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
git config --global user.email 'github-actions[bot]@users.noreply.github.com'
- name: Unit tests
run: |
pytest -v
pytest -vv
- name: Coverage report
run: |
pytest --cov=./ --cov-report=xml
Expand Down
8 changes: 4 additions & 4 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ databooks = "databooks.cli:app"

[tool.poetry.dependencies]
python = "^3.7"
typer = "^0.4.0"
typer = ">=0.4.0,<1.0.0"
rich = "^12.6.0"
pydantic = "^1.8.2"
GitPython = "^3.1.24"
Expand Down
9 changes: 3 additions & 6 deletions tests/test_cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -136,10 +136,7 @@ def test_meta__script(tmp_path: Path) -> None:

result = runner.invoke(app, ["meta", str(py_path)])
assert result.exit_code == 2
assert (
"Expected either notebook files, a directory or glob expression."
in result.output
)
assert "Expected either notebook files, a directory or glob " in result.output


def test_meta__no_confirm(tmp_path: Path) -> None:
Expand All @@ -151,9 +148,9 @@ def test_meta__no_confirm(tmp_path: Path) -> None:

assert result.exit_code == 1
assert JupyterNotebook.parse_file(nb_path) == TestJupyterNotebook().jupyter_notebook
assert result.output == (
assert result.output.startswith(
"1 files will be overwritten (no prefix nor suffix was passed)."
" Continue? [y/n]: \nAborted!\n"
" Continue? [y/n]:"
)


Expand Down

0 comments on commit 020958b

Please sign in to comment.