Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robustify tests of iterable_subprocess #614

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Robustify tests of iterable_subprocess #614

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b83c101
robustify tests of `iterable_subprocess`
christian-monch Feb 2, 2024
d1fc39f
Update datalad_next/iterable_subprocess/test_iterable_subprocess.py
christian-monch Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions datalad_next/iterable_subprocess/test_iterable_subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,9 +332,16 @@ def test_error_returncode_available_from_generator_with_exception():
assert ls.returncode != 0


def test_success_returncode_available_from_generator_with_exception():
def test_returncode_available_from_generator_with_exception():
with pytest.raises(StopIteration):
with iterable_subprocess(['echo', 'a'], ()) as echo:
while True:
next(echo)
assert echo.returncode == 0
# On a Linux system, all exceptions that are raised before the subprocess
# exited will lead to a -15 return code. If StopIteration is raised, the
# subprocess will either have terminated which results in a 0-return code,
# or the subprocess is still running and will therefore be terminated which
# results in a -15 return code. Any other exception than StopIteration,
# e.g. a CommandError because echo could not be found, would lead to an
# early test-exit and not proceed to the assign-statement.
assert echo.returncode in (0, -15)
Loading