add OscarMovie.java and OscarMovie.yml #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/test/java/net/datafaker/OscarMovieTest.java
|
Hello @bodiam , are you willing to merge this PR. If you do it, our group will be fairly thrilled!!! |
|
Absolutely! As a general feedback, there's a small issue, which is the casing of the yml file. I think we only use lowercase for that, so it would be great to keep it consist. However, I think this is something we can fix later, so I see nothing stopping us from merging this PR! Great work, thank you! Merged! |
|
Thanks, our group really appreciate it!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add OscarMovie.java and OscarMovie.yml DiUS/java-faker#712 and DiUS/java-faker#713