feat: --find-renames for discovering renames based on content #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I do not see a way around the O(n^2) runtime, except with some heuristics. But I think in most use-cases that is acceptable.
|
fwiesel
force-pushed
the
content_diff
branch
2 times, most recently
from
fcf340c to
3537cb4
Compare
mumoshu
reviewed
Jan 9, 2022
mumoshu
reviewed
Jan 9, 2022
mumoshu
reviewed
Jan 9, 2022
The test case contains blank lines with white-spaces and many editors do trim those, so we adopt the test as well as the code to not indent blank lines
The three steps are called in three places, we better combine them into a single function.
By encapsulating the parameters into a struct and a corresponding cmd.options package helper functions, we need only to change the code in two places when adding a new parameter instead of four (for each subcommand).
If we rename objects, they will appear as add and remove actions, which makes it difficult to assess the semantic delta, which may only be a simple renaming. The current implementation creates a diff between every added & removeed item of the same kind, which means at worst O(m*n) runtime. So it should only be enabled if such changes are rare
|
When implementing the tests, I was running into some minor issues I couldn't explain, so I split up the changes into several commits and refactored the code to limit the change required to implement the functionality. |
mumoshu
approved these changes
Jan 22, 2022
mumoshu
changed the title
mumoshu
changed the title
mumoshu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we rename objects, they will appear as
add and remove actions, which makes it difficult
to assess the semantic delta, which may only be
a simple renaming.
The current implementation creates potentially
a diff between every add/remove item, which
means O(n^2) runtime. So it should only be
enabled if such changes are rare