Use a mktemp random directory for installation (repeated PR)

[keymon]

Reissuing the PR #269 closed by stale bot
Updated with master

Do not hardcode a static directory for temporary files, as it
might cause problems when running in a multi-user system
(ie: orphan files owned by other users).

Use mktemp -d instead.

Fixes #241
This was already tested in #269

[ohartl]

rmTempDir is a nice addition for cleanup, but a call to that at the end seems to be missing. Thus temp files are only cleaned up in case of a failure currently. Or is fail_trap naming wrong?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[keymon]

It is not stale, it is just not getting attention. Needs merging :)

[keymon]

rmTempDir is a nice addition for cleanup, but a call to that at the end seems to be missing. Thus temp files are only cleaned up in case of a failure currently. Or is fail_trap naming wrong?

yep, the trap is on EXIT, so it will be always executed.

Maybe exit_trap is a better name

[ohartl]

rmTempDir is a nice addition for cleanup, but a call to that at the end seems to be missing. Thus temp files are only cleaned up in case of a failure currently. Or is fail_trap naming wrong?

yep, the trap is on EXIT, so it will be always executed.

Maybe exit_trap is a better name

Sorry I was confused there for a second, thanks for clearing that up.

Its now not only waiting for a failure anymore, so naming is bit wrong. I think exit_trap is nice! But removing the dir in in a trap is nice.

[keymon]

@ohartl OK, I rebased and renamed the function

[ohartl]

@databus23 Needs merging

[mumoshu]

LGTM. Thanks a lot for your contribution ☺️