Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cygpath for HELM_BIN #287

Merged
merged 2 commits into from
Jan 9, 2022
Merged

Use cygpath for HELM_BIN #287

merged 2 commits into from
Jan 9, 2022

Conversation

jkroepke
Copy link
Contributor

@jkroepke jkroepke commented Jun 7, 2021

Since 7f10f25 HELM_BIN instead helm is used.

If helm plugin install is running on cygwin, an error occurred:

# Installed plugin: secrets
...
# D:\a\helm-secrets\helm-secrets\tests\.tmp\cache\CYGWIN_NT-10.0\helm\home\helm\plugins\helm-diff/install-binary.sh: line 9: C:\hostedtoolcache\windows\helm\3.6.0\x64\windows-amd64\helm.exe: command not found
...

# Error: plugin install hook for "diff" exited with error

Like HELM_PLUGIN_DIR, HELM_BIN needs to be translated on cygwin, too.

@stale
Copy link

stale bot commented Sep 6, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 6, 2021
@jkroepke
Copy link
Contributor Author

.

@stale stale bot removed the stale label Sep 13, 2021
@stale
Copy link

stale bot commented Jan 3, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 3, 2022
@stale stale bot removed the stale label Jan 9, 2022
Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Honestly speaking I don't use cygwin and have no expertise on it but from what I can see from code I tried to rebase changes onto the lastest master. I hope it works.

@mumoshu
Copy link
Collaborator

mumoshu commented Jan 9, 2022

It would be great if anyone could enahnce our CI workflow to cover cygwin (if it's possible).

@mumoshu mumoshu merged commit 19a5207 into databus23:master Jan 9, 2022
@jkroepke jkroepke mentioned this pull request Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants