Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for 'helm diff upgrade --install' #218

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Added support for 'helm diff upgrade --install' #218

merged 1 commit into from
Jul 20, 2020

Conversation

MFAshby
Copy link
Contributor

@MFAshby MFAshby commented Jun 3, 2020

This behaves exactly the same as 'helm diff upgrade --allow-unreleased',
but it matches the same arguments as helm itself, so that check scripts
and deployment scripts can be basically the same, e.g.
check:
helm diff upgrade --install myapp ./myapp
install:
helm upgrade --install myapp ./myapp

and this'll work regardless of whether the release exists or not.
Ref #108

This behaves exactly the same as 'helm diff upgrade --allow-unreleased',
but it matches the same arguments as helm itself, so that check scripts
and deployment scripts can be basically the same, e.g.
check:
helm diff upgrade --install myapp ./myapp
install:
helm upgrade --install myapp ./myapp

and this'll work regardless of whether the release exists or not.
Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MFAshby Thanks! LGTM.

Note that this doesn't resolve the original issue, so I'll reopen the issue once this gets merged.
But this feature itself should be great to have! Thanks again for your contribution.

@mumoshu mumoshu merged commit e186caa into databus23:master Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants