Add converting files to bigWig #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nleroy917
reviewed
Oct 22, 2024
Comment on lines
+128
to
+129
| start_position: i32, | ||
| stepsize: i32, |
There was a problem hiding this comment.
u32 since these won't ever be negative?
nleroy917
approved these changes
Oct 22, 2024
| start_position: i32, | ||
| stepsize: i32, | ||
| ) { | ||
| let path = std::path::Path::new(&filename).parent().unwrap(); |
There was a problem hiding this comment.
Should we catch any potential errors instead of unwrap()?
| } | ||
|
|
||
| /// Converts uniwig generated bedGraphs to bigWig files | ||
| pub fn write_bw_files(location: &str, chrom_sizes: &str, num_threads: i32, zoom_level: i32) { |
There was a problem hiding this comment.
What about changing the type of num_threads and zoom_level to u32? They are being converted anyways down there
|
leaving branch open to continue bam work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uniwig will create bedGraphs and then use these (in tandem with bigTools) to create bigWig files.