Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log errors in the build process #2

Merged
merged 1 commit into from
Mar 19, 2018
Merged

Conversation

BridgeAR
Copy link
Contributor

@BridgeAR BridgeAR commented Mar 5, 2018

This makes sure errors are reported in case writeFile fails. This will otherwise fail in Node.js 10.x, see nodejs/node#18668.

@BridgeAR
Copy link
Contributor Author

Ping @ruyadorno @heldr

@heldr
Copy link
Member

heldr commented Mar 19, 2018

LGTM 🍵 , thanks!

@heldr heldr merged commit 8a95421 into data-uri:master Mar 19, 2018
@ruyadorno
Copy link

awesome! nice to see you around @BridgeAR 🎉 muito obrigado 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants