New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(coinjoin): 8.3.0 crashes #685

Open

Syn-McJ wants to merge 4 commits into dashpay:develop from Syn-McJ:fix/coinjoin-crashes

Member

Syn-McJ commented Feb 23, 2025

Issue being fixed or feature implemented

Wallet has some crashes related to fiat formatting

What was done?

Making sure fiatFormatter is synchronized across threads
Ensuring feevalue isn't overflowing

How Has This Been Tested?

QA

Breaking Changes

Checklist:

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated relevant unit/integration/functional/e2e tests
I have made corresponding changes to the documentation

For repository code-owners and collaborators only

I have assigned this pull request to a milestone

Syn-McJ added 4 commits

February 12, 2025 20:06


          fix: TxDetailModel crash

0ed3eb6


          fix: ensuring safe substruction in CoinJoinMixingTxSet

676c00a


          fix: build error

7175a96


          fix: fiatFormatter crash

aeb9b3b

Syn-McJ requested a review from pankcuf

February 23, 2025 13:41

Syn-McJ self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet