Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(coinbase): buy and transfer fix #679

Merged
merged 1 commit into from
Feb 13, 2025
Merged

fix(coinbase): buy and transfer fix #679

merged 1 commit into from
Feb 13, 2025

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Jan 14, 2025

Issue being fixed or feature implemented

Coinbase Buy Dash doesn't work due to some fields in the order struct not being optional

What was done?

  • Make fields optional
  • Rename fields according to updated Coinbase API

How Has This Been Tested?

QA

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Syn-McJ Syn-McJ requested a review from pankcuf January 14, 2025 04:42
@Syn-McJ Syn-McJ self-assigned this Jan 14, 2025
@Syn-McJ Syn-McJ merged commit aec50e0 into dashpay:master Feb 13, 2025
1 check passed
@Syn-McJ Syn-McJ deleted the fix/coinbase-buy-dash branch February 13, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pankcuf pankcuf pankcuf approved these changes

Assignees

@Syn-McJ Syn-McJ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Syn-McJ @pankcuf