Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(uphold): align Uphold and Coinbase portals #605

Merged
merged 10 commits into from
Sep 25, 2023

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Sep 24, 2023

Issue being fixed or feature implemented

Uphold portal UI needs to be unified with Coinbase and the Topper widget added as the Buy option.

What was done?

  • CoinbaseViewController is refactored into IntegrationViewController to be shared across Coinbase and Uphold.
  • Integration VC and Buy&Sell portal VC are moved into a separate storyboard.
  • Coinbase and Uphold models are refactored to derive from the same parent class.
  • Integration Portal UI is aligned with the latest design.
  • Obsolete Uphold code is removed.
  • Some bugs with displaying Uphold balance on the Buy&Sell screen are fixed.
  • OTP input for Uphold is changed to submit automatically after 6 digits are entered.

How Has This Been Tested?

QA

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Syn-McJ Syn-McJ requested a review from pankcuf September 24, 2023 05:24
@Syn-McJ Syn-McJ self-assigned this Sep 24, 2023
Copy link
Collaborator

@pankcuf pankcuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Syn-McJ Syn-McJ merged commit f6de2d2 into dashpay:develop Sep 25, 2023
@Syn-McJ Syn-McJ deleted the feature/uphold-align-portal branch September 25, 2023 03:33
@pankcuf pankcuf mentioned this pull request Oct 2, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants