Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: New confirmation controller #571

Merged
merged 13 commits into from
Jul 13, 2023
Merged

feat: New confirmation controller #571

merged 13 commits into from
Jul 13, 2023

Conversation

tikhop
Copy link
Collaborator

@tikhop tikhop commented Jul 12, 2023

Issue being fixed or feature implemented

New confirmation controller

What was done?

  • Implement new confirmation screen in swift
  • Implement Uphold confirmation controller basing on the new confirmation screen
  • Improve styled buttons

How Has This Been Tested?

QA, Manually

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

tikhop added 13 commits July 11, 2023 02:27
@tikhop
feat(ui): Implement 'GrayButton'
8457a6c
@tikhop
feat(ui): Implement 'ConfirmPaymentViewController'
0075e7e
@tikhop
feat: Add observers into 'CurrencyExchange' manager
8c093f5
@tikhop
feat: Show payment details
7be1b8a
@tikhop
feat(ui): Present 'ConfirmPaymentViewController' using 'pageSheet' st…
0313e62 
…yle with custom implementation
@tikhop
feat(ui): Animate confirm button title while tx is publishing
2f5a1d0
@tikhop
refactor(ui): Use 'ConfirmPaymentViewController' as a base confirmati…
995e1b7 
…on screen for Uphold flow
@tikhop
chore(ui): Code clean up
378cadb
@tikhop
feat: Show auth alert before confirmation screen
ff4812c
@tikhop
fix: Improve showing view controller stack when payment in progress
3121323
@tikhop
fix: Make sure tab bar retains home and tools screens
4b37db0
@tikhop
fix: Use the right color for action button when using it from storybo…
28d9630 
…ard/xib
@tikhop
feat: Pass selected fiat currency in order to present correct value a…
1a0893d 
…t confirmation state
@tikhop tikhop requested a review from Syn-McJ July 12, 2023 16:25
@tikhop tikhop marked this pull request as ready for review July 12, 2023 16:25
Syn-McJ
Syn-McJ approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@Syn-McJ Syn-McJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@tikhop tikhop merged commit 0ffb54a into develop Jul 13, 2023
@tikhop tikhop deleted the feature/new-confirmation-controller branch July 13, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Syn-McJ Syn-McJ Syn-McJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tikhop @Syn-McJ