Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Lock balance on 'ProvideAmountController' when sending from quick scan #566

Merged
merged 1 commit into from
Jul 11, 2023
Merged

feat: Lock balance on 'ProvideAmountController' when sending from quick scan #566

merged 1 commit into from
Jul 11, 2023
+26 −2

Conversation

tikhop
Copy link
Collaborator

@tikhop tikhop commented Jul 11, 2023

Issue being fixed or feature implemented

Lock balance on 'ProvideAmountController' when sending from quick scan

What was done?

  • Make it possible to lock balance and request auth before trying to show
  • Pass the locksBalance flag when sending from quick scan

How Has This Been Tested?

Manually

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@tikhop tikhop requested a review from pankcuf July 11, 2023 15:45
@tikhop tikhop marked this pull request as ready for review July 11, 2023 15:45
@pankcuf pankcuf merged commit d5adc4d into develop Jul 11, 2023
@tikhop tikhop deleted the feature/quick-send-lock-balance branch July 11, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pankcuf pankcuf pankcuf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tikhop @pankcuf