-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add approval test setup #415
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38b27a5
to
a21a5e4
Compare
50e8433
to
2d46576
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to DEV-3400
Problem Statement
There is a need for refactoring, so that future additions and bugfixes can be applied in a timely manner. The fear is, that although the code will be "only" refactored, that this might break the behavior in unforeseen ways.
Desired Outcome
Have a safety net in place, so that refactoring can be done without fear.
Solution
Add approval tests. Approval tests are a technique to write test, where the output of a action is persisted to disks and subsequent calls are compared to the version stored on disk. Another name is snapshot tests. This technique is usually applied to legacy codebases, where there is not a good unit test coverage and where to add good unit tests, the code needs to be first refactored to make it testable.