Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(crash reporting): add crash reporting using sentry #396

Merged
merged 4 commits into from
Nov 1, 2023
Merged

refactor(crash reporting): add crash reporting using sentry #396

merged 4 commits into from
Nov 1, 2023

Conversation

subotic
Copy link
Contributor

@subotic subotic commented Nov 1, 2023

No description provided.

@linear Linear
Copy link

linear bot commented Nov 1, 2023

DEV-2887 Add sentry.io error reporting to Sipi

https://sentry.io

Sentry.io provides a c++ client that should allow us to catch and report Sipi crashes and send them to Datadog via the Sentry.io integration.

  • add sentry.io c++ sdk
  • initialize sentry in main
  • add sentry config to sipi config
  • skip sentry init if no sentry config is provided

@subotic subotic self-assigned this Nov 1, 2023
@subotic subotic marked this pull request as ready for review November 1, 2023 13:30
BalduinLandolt
BalduinLandolt approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to approve this pretty blindly, but it looks reasonable. There are some comments you could probably remove.

@subotic subotic merged commit 96efa79 into main Nov 1, 2023
@subotic subotic deleted the feature/dev-2887-add-sentryio-error-reporting-to-sipi branch November 1, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seakayone seakayone seakayone approved these changes

@BalduinLandolt BalduinLandolt BalduinLandolt approved these changes

Assignees

@subotic subotic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@subotic @seakayone @BalduinLandolt