Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Simplify delete value pre-checks #3524

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

seakayone
Copy link
Contributor

  • move auth logic into auth service
  • simplify

Description

@seakayone seakayone changed the title refactor/simplify refactor: Simplify delete value pre-checks Mar 3, 2025
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 20.89%. Comparing base (6ebe8e7) to head (649ee0b).
Report is 223 commits behind head on main.

Files with missing lines Patch % Lines
...knora/webapi/responders/v2/ValuesResponderV2.scala 0.00% 13 Missing ⚠️
...pi/slice/common/api/AuthorizationRestService.scala 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3524       +/-   ##
===========================================
- Coverage   83.04%   20.89%   -62.16%     
===========================================
  Files         290      317       +27     
  Lines       23087    22531      -556     
===========================================
- Hits        19172     4707    -14465     
- Misses       3915    17824    +13909     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants