Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] envelope #211

Closed
wants to merge 4 commits into from
Closed

Conversation

NithyaNN3
Copy link

@NithyaNN3 NithyaNN3 commented Mar 28, 2025

  • added envelope function + added test cases

@aardrop
Copy link

aardrop commented Apr 1, 2025

Hey @NithyaNN3 and @deanpapas, did you all mean to have these two features together in one PR? It looks like the square feature and the envelope are both in this PR.

Best practice is 1 feature to 1 PR unless @lukas-h wants it this way. I'm comfortable reviewing as is in favor of expedience, but wanted to make sure this is intentional.

@NithyaNN3
Copy link
Author

NithyaNN3 commented Apr 1, 2025

Hey @aardrop, please ignore this PR but all our commits will be squashed and sent in together with Dean's fork unless you prefer we change it for our next sprint.
I was trying to create a PR to merge my branch with Dean's main fork but it created one here instead

@NithyaNN3 NithyaNN3 closed this Apr 1, 2025
@NithyaNN3 NithyaNN3 reopened this Apr 1, 2025
@NithyaNN3 NithyaNN3 closed this Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants