Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failure only reporter #2190

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Add failure only reporter #2190

merged 2 commits into from
Mar 4, 2024

Conversation

natebosch
Copy link
Member

Closes #829

Copies the expanded reporter and test and removes output unrelated to
failed tests.

Closes #829

Copies the expanded reporter and test and removes output unrelated to
failed tests.
@natebosch natebosch requested a review from jakemac53 February 29, 2024 01:05
@natebosch
Copy link
Member Author

Some details worth getting agreement on:

  • Naming. I'm going with -r failures-only to be specific, but if anyone thinks we should do --quiet or anything else we should pick a good name to start with.
  • This currently doesn't print skips since a skip doesn't cause a failure. We still show the number skipped at the end of the test.
  • We do print the final line with the number of passing/failing/skipped tests. So there is some output even for fully passing suites. We could instead be totally silent for passing runs, but I think the main goal is to reduce noise, and the summary line carries a lot of signal.

@jakemac53
Copy link
Contributor

jakemac53 commented Feb 29, 2024

Naming. I'm going with -r failures-only to be specific, but if anyone thinks we should do --quiet or anything else we should pick a good name to start with.

I could see doing --quiet but I think this is more consistent with how we generally configure reporters. So I think it is good as is.

This currently doesn't print skips since a skip doesn't cause a failure. We still show the number skipped at the end of the test.

SGTM

We do print the final line with the number of passing/failing/skipped tests. So there is some output even for fully passing suites. We could instead be totally silent for passing runs, but I think the main goal is to reduce noise, and the summary line carries a lot of signal.

I think its still worth printing the summary also, so SGTM

@natebosch
Copy link
Member Author

We also print the time since starting the test run today - looking at this again I'm leaning towards removing that. In the compact reporter it makes sense because we keep updating the same display of the time on the current line in the typical case. In the expanded reporter it can be used to see the delta between a test start and test failure. Absent other information, knowing the time since test start for an arbitrary failure is not useful.

Knowing the full runtime could be useful, but can also be easily measured externally (as long as it's not a problem picking up the test runner overhead).

Update test_core constraint.
@natebosch natebosch merged commit 7724aab into master Mar 4, 2024
35 checks passed
@natebosch natebosch deleted the quiet-reporter branch March 4, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a quieter reporter that only prints information for failures
2 participants