Support targeting compilers via platform selectors #1911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[<platform-selector>:]<compiler>
jakemac53
commented
Feb 6, 2023
| @@ -167,21 +166,12 @@ class Runner { | |||
| var testOn = _config.suiteDefaults.metadata.testOn; | |||
| if (testOn == PlatformSelector.all) return; | |||
|
|
|||
| var runtimes = _config.suiteDefaults.runtimes | |||
| var unsupportedRuntimes = _config.suiteDefaults.runtimes | |||
There was a problem hiding this comment.
This is actually just a revert of what I had tried to do earlier, it should match the original logic now. What I was trying to do no longer makes sense with the fallback to a default compiler on any runtime that has no compiler specified.
natebosch
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
--compilerflag to support a syntax like this--compiler [<platform-selector>:]<compiler>.This is quite handy because it allows for instance
-c web:dart2jsor-c chrome:dart2wasmetc. It ultimately does not increase the complexity a lot either.