New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shorten the issue badges #456

Merged

devoncarew merged 1 commit into master from shorter_issues_badges

Nov 21, 2024

Member

devoncarew commented Nov 21, 2024

shorten the issue badges

when displayed in the table the longer ones can get very small.

I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

See our contributor guide for general expectations for PRs.
Larger or significant changes should be discussed in an issue before creating a PR.
Contributions to our repos should follow the Dart style guide and use dart format.
Most changes should add an entry to the changelog and may need to rev the pubspec package version.
Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.


          shorten the issue badges

b2467ae

kevmoo approved these changes

View reviewed changes

Member

kevmoo left a comment

Uh...sure!

devoncarew merged commit a2708cd into master

22 checks passed

devoncarew deleted the shorter_issues_badges branch

November 21, 2024 16:39

copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request


          [deps] rev core, dartdoc, http, shelf

f7993d5

Revisions updated by `dart tools/rev_sdk_deps.dart`.

core (https://github.com/dart-lang/core/compare/6af0821..1de8372):
  1de83727  2024-11-20  Lasse R.H. Nielsen  Implement full Unicode 16.0.0 extended grapheme breaking. (dart-lang/core#719)

dartdoc (https://github.com/dart-lang/dartdoc/compare/f8a55e4..c7f1160):
  c7f11603  2024-11-20  Sam Rawlins  Fix sidebars via correct web API for anchor href values (dart-lang/dartdoc#3934)

http (https://github.com/dart-lang/http/compare/e37093f..79470d0):
  79470d0  2024-11-19  Brian Quinlan  Include names in argument lists (dart-lang/http#1408)

shelf (https://github.com/dart-lang/shelf/compare/0bb44cb..a2708cd):
  a2708cd  2024-11-21  Devon Carew  shorten the issue badges (dart-lang/shelf#456)

Change-Id: Iee20d2300d1bf0e43a57b352b73235ae24fa5e51
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396960
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet