Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enum in analyzer serializer not sorted/refactor the format in Google3 #39451

Closed
kallentu opened this issue Nov 19, 2019 · 1 comment
Closed

Enum in analyzer serializer not sorted/refactor the format in Google3 #39451

kallentu opened this issue Nov 19, 2019 · 1 comment
Assignees
@scheglov
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) dartdev-quick-fix Issues with analysis server (quick) fixes P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@kallentu
Copy link
Member

For context: https://dart-review.googlesource.com/c/sdk/+/125554/1/pkg/analyzer/lib/src/summary/idl.dart#2022

The UnlinkedTokenType enums in idl.dart are no longer sorted.
Need to do a refactor to change the format.
@mit-mit mit-mit added the area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. label Nov 20, 2019
@srawlins srawlins added the dartdev-quick-fix Issues with analysis server (quick) fixes label Jun 16, 2020
@srawlins srawlins added the P3 A lower priority bug or feature request label Dec 2, 2020
@srawlins srawlins added the type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) label Nov 18, 2021
@srawlins srawlins added the contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) label May 20, 2022
@scheglov
Copy link
Contributor

https://dart-review.googlesource.com/c/sdk/+/371260

copybara-service bot pushed a commit that referenced this issue Jun 13, 2024
@scheglov
DevX. Issue 39451. Sort (almost) UnlinkedTokenType.
09d1522 
I decided to keep NOTHING at the top still.
The google3 is not an issue any more, AFAIK.

Bug: #39451
Change-Id: Iac96c64326b15527268347ebcadb35c616605279
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/371260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scheglov scheglov

Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) dartdev-quick-fix Issues with analysis server (quick) fixes P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@srawlins @scheglov @mit-mit @kallentu