Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add void whitelist item for switch expression case #3026

Merged
merged 2 commits into from
May 2, 2023
Merged

Add void whitelist item for switch expression case #3026

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c23aa3a
Add void usage whitelist item for switch expression case
eernstg Apr 28, 2023
3a7451f
Review response
eernstg Apr 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions accepted/future-releases/0546-patterns/feature-specification.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2158,6 +2158,20 @@ issue an error since the empty placeholder switch is no longer exhaustive,
allowing the user to find all the places in the code that need to be updated to
handle the new subtype.*

We add the following item to the list of [locations where it is not an error
to have an expression of type `void`][void allowlist]:

[void allowlist]:https://github.com/dart-lang/language/blob/f58f8c5d24eed253db41474a3149f7b79a274c63/specification/dartLangSpec.tex#L21981

- In a `<switchExpressionCase>` of the form `p => e`, `e` may have type `void`.

*This means that we treat switch expressions similarly to conditional
expressions with respect to the type `void`. When one or more cases in a switch
expression have type `void`, the switch expression as a whole will have type
`void`, which means that it can in turn only occur in a location which allows
having type `void`. For example,
`void f() => switch (null) { null => print('Got yer!') };` is OK.*

### Variables and scope

Patterns often exist to bind new variables. The language must ensure that the
Expand Down