Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new native_assets #941

Merged
merged 52 commits into from
Feb 21, 2025
Merged

Update to new native_assets #941

merged 52 commits into from
Feb 21, 2025

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Jan 30, 2025

Some changes to:

  • the generated files, which should be merged upstream in the generator.
  • the rust build steps - the hosted binaries should be updated as well.

Introducing a linker script treeshaking unused symbols, but this will compile on linux only due to CLinker not being available on other platforms at the moment.

As user defines are not yet available, dart-lang/native#39, find and read the pubspec by recursing up from the out directory.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link

github-actions bot commented Jan 30, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
intl4x Breaking 0.10.1 0.11.0-wip 0.11.0 ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️
File Coverage
pkgs/intl4x/example_native/bin/example_native.dart 💔 Not covered
pkgs/intl4x/hook/build.dart 💔 Not covered
pkgs/intl4x/hook/link.dart 💔 Not covered
pkgs/intl4x/lib/intl4x.dart 💚 100 %
pkgs/intl4x/lib/src/collation/collation_4x.dart 💚 100 %
pkgs/intl4x/lib/src/collation/collation_ecma.dart 💚 100 %
pkgs/intl4x/lib/src/collation/collation_impl.dart 💚 100 %
pkgs/intl4x/lib/src/collation/collation_options.dart 💔 Not covered
pkgs/intl4x/lib/src/collation/collation_stub.dart 💔 Not covered
pkgs/intl4x/lib/src/collation/collation_stub_4x.dart 💔 Not covered
pkgs/intl4x/lib/src/data_4x.dart 💚 60 %
pkgs/intl4x/lib/src/datetime_format/datetime_format_4x.dart 💔 Not covered
pkgs/intl4x/lib/src/datetime_format/datetime_format_ecma.dart 💚 100 %
pkgs/intl4x/lib/src/datetime_format/datetime_format_impl.dart 💚 100 %
pkgs/intl4x/lib/src/datetime_format/datetime_format_options.dart 💚 33 %
pkgs/intl4x/lib/src/datetime_format/datetime_format_stub.dart 💔 Not covered
pkgs/intl4x/lib/src/datetime_format/datetime_format_stub_4x.dart 💔 Not covered
pkgs/intl4x/lib/src/display_names/display_names.dart 💚 100 %
pkgs/intl4x/lib/src/display_names/display_names_4x.dart 💚 69 %
pkgs/intl4x/lib/src/display_names/display_names_ecma.dart 💚 100 %
pkgs/intl4x/lib/src/display_names/display_names_impl.dart 💚 100 %
pkgs/intl4x/lib/src/display_names/display_names_options.dart 💚 20 %
pkgs/intl4x/lib/src/display_names/display_names_stub.dart 💔 Not covered
pkgs/intl4x/lib/src/display_names/display_names_stub_4x.dart 💔 Not covered
pkgs/intl4x/lib/src/hook_helpers/build_options.dart 💔 Not covered
pkgs/intl4x/lib/src/hook_helpers/hashes.dart 💔 Not covered
pkgs/intl4x/lib/src/hook_helpers/shared.dart 💔 Not covered
pkgs/intl4x/lib/src/list_format/list_format_4x.dart 💚 100 %
pkgs/intl4x/lib/src/list_format/list_format_ecma.dart 💚 100 %
pkgs/intl4x/lib/src/list_format/list_format_impl.dart 💚 100 %
pkgs/intl4x/lib/src/list_format/list_format_stub.dart 💔 Not covered
pkgs/intl4x/lib/src/list_format/list_format_stub_4x.dart 💔 Not covered
pkgs/intl4x/lib/src/locale/locale.dart 💚 100 %
pkgs/intl4x/lib/src/locale/locale_ecma.dart 💚 100 %
pkgs/intl4x/lib/src/locale/locale_native.dart 💚 88 %
pkgs/intl4x/lib/src/number_format/number_format_4x.dart 💚 94 %
pkgs/intl4x/lib/src/number_format/number_format_ecma.dart 💚 98 %
pkgs/intl4x/lib/src/number_format/number_format_impl.dart 💚 100 %
pkgs/intl4x/lib/src/number_format/number_format_options.dart 💚 80 %
pkgs/intl4x/lib/src/number_format/number_format_stub.dart 💔 Not covered
pkgs/intl4x/lib/src/number_format/number_format_stub_4x.dart 💔 Not covered
pkgs/intl4x/lib/src/options.dart 💚 25 %
pkgs/intl4x/lib/src/plural_rules/plural_rules.dart 💚 71 %
pkgs/intl4x/lib/src/plural_rules/plural_rules_4x.dart 💚 100 %
pkgs/intl4x/lib/src/plural_rules/plural_rules_ecma.dart 💚 75 %
pkgs/intl4x/lib/src/plural_rules/plural_rules_impl.dart 💚 100 %
pkgs/intl4x/lib/src/plural_rules/plural_rules_options.dart 💚 67 %
pkgs/intl4x/lib/src/plural_rules/plural_rules_stub.dart 💔 Not covered
pkgs/intl4x/lib/src/plural_rules/plural_rules_stub_4x.dart 💔 Not covered
pkgs/intl4x/lib/src/utils.dart 💚 75 %
pkgs/intl4x/tool/regenerate_hashes.dart 💔 Not covered
pkgs/intl4x/tool/write_option_file.dart 💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Copy link

github-actions bot commented Feb 3, 2025

Package publishing

Package Version Status Publish tag (post-merge)
package:intl 0.20.3-wip WIP (no publish necessary)
package:intl4x 0.10.2 ready to publish intl4x-v0.10.2
package:intl_translation 0.20.1 already published at pub.dev
package:messages_shrinker 0.2.2-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Feb 3, 2025
@mosuem mosuem requested a review from robertbastian February 17, 2025 09:46
robertbastian added a commit to unicode-org/icu4x that referenced this pull request Feb 19, 2025
`package:meta` switched away from `RecordMetadata` in favor of the
argumentless `RecordUse`, so introduce a custom annotation here which
can be used for filtering information in the Dart link hook later on.

Related to dart-lang/i18n#941

These manual changes must be upstreamed into the Diplomat generator.

---------

Co-authored-by: Robert Bastian <4706271+robertbastian@users.noreply.github.com>
@mosuem mosuem requested a review from robertbastian February 20, 2025 14:11
@mosuem mosuem enabled auto-merge (squash) February 20, 2025 14:12
@mosuem mosuem requested a review from robertbastian February 21, 2025 16:39
@mosuem mosuem merged commit c3e9fe2 into main Feb 21, 2025
21 checks passed
@mosuem mosuem deleted the updateIntl4x2 branch February 21, 2025 17:06
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Mar 7, 2025
…, tools, vector_math, web, webdriver

Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/34561d6..6c770bf):
  6c770bfb  2025-03-01  dependabot[bot]  Bump the github-actions group with 5 updates (dart-lang/dartdoc#4011)
  06233c76  2025-02-26  Parker Lougheed  Use nested scss in nav and footer styles (dart-lang/dartdoc#4006)
  4847677c  2025-02-26  Sam Rawlins  Support the stats flag when documenting the testing package (dart-lang/dartdoc#4008)

ecosystem (https://github.com/dart-lang/ecosystem/compare/06bbbff..a3cc42d):
  a3cc42d  2025-03-06  Devon Carew  Update publish_internal.yaml (dart-lang/ecosystem#345)
  25f0fb2  2025-03-04  Devon Carew  Update README.md (dart-lang/ecosystem#344)
  331d35d  2025-03-01  dependabot[bot]  Bump the github-actions group with 5 updates (dart-lang/ecosystem#343)

i18n (https://github.com/dart-lang/i18n/compare/06a664f..bdeec25):
  bdeec25  2025-03-04  Moritz  Publish `package:intl4x: 0.11.0` (dart-lang/i18n#953)
  d84a927  2025-03-04  Moritz  Update publishing workflow
  547ce9f  2025-03-01  dependabot[bot]  Bump the github-actions group with 2 updates (dart-lang/i18n#952)
  c6b911b  2025-02-21  dependabot[bot]  Bump the github-actions group across 1 directory with 4 updates (dart-lang/i18n#949)
  c3e9fe2  2025-02-21  Moritz  Update to new native_assets (dart-lang/i18n#941)

protobuf (https://github.com/dart-lang/protobuf/compare/610943a..7838e44):
  7838e44  2025-03-07  Ömer Sinan Ağacan  Prefix grpc method 'call' and 'request' arguments with '$' to avoid shadowing user methods with the same name (google/protobuf.dart#964)
  125fe9c  2025-03-02  dependabot[bot]  Bump dart-lang/setup-dart from 1.7.0 to 1.7.1 (google/protobuf.dart#965)
  fb77c7c  2025-03-02  dependabot[bot]  Bump actions/cache from 4.2.0 to 4.2.2 (google/protobuf.dart#966)

shelf (https://github.com/dart-lang/shelf/compare/b39e611..2af8529):
  2af8529  2025-03-04  Devon Carew  Update publish.yaml (dart-lang/shelf#473)
  f5ae797  2025-03-01  dependabot[bot]  Bump the github-actions group with 2 updates (dart-lang/shelf#471)

sync_http (https://github.com/dart-lang/sync_http/compare/47e6b26..dc54465):
  dc54465  2025-03-02  dependabot[bot]  Bump dart-lang/setup-dart from 1.7.0 to 1.7.1 (google/sync_http.dart#54)

test (https://github.com/dart-lang/test/compare/a833663..9e349d0):
  9e349d0e  2025-03-06  Jonas Finnemann Jensen  Suggest using `dart pub add dev:checks` (dart-lang/test#2467)
  e941dbac  2025-03-04  Devon Carew  Update publish.yaml (dart-lang/test#2465)
  32bf9b73  2025-03-01  dependabot[bot]  Bump the github-actions group with 5 updates (dart-lang/test#2462)

tools (https://github.com/dart-lang/tools/compare/b51f39d..d67cd00):
  d67cd002  2025-03-07  Parker Lougheed  [pub_semver] Remove dependency on `package:meta` (dart-lang/tools#2021)
  04667d7e  2025-03-06  Parker Lougheed  [pub_semver] Discourage modification of properties intended to be unmodifiable (dart-lang/tools#2020)
  b23129b9  2025-03-04  Devon Carew  Update publish.yaml (dart-lang/tools#2025)
  9765c2aa  2025-02-25  Parker Lougheed  [package_config] Implement relational operators for `LanguageVersion` (dart-lang/tools#2016)

vector_math (https://github.com/google/vector_math.dart/compare/533c513..f08d7d2):
  f08d7d2  2025-03-01  dependabot[bot]  Bump dart-lang/setup-dart in the github-actions group (google/vector_math.dart#340)

web (https://github.com/dart-lang/web/compare/c2d5f63..4854093):
  4854093  2025-03-04  Srujan Gaddam  Add pull request and id-token write permissions to publish.yaml (dart-lang/web#351)
  33ed133  2025-03-01  dependabot[bot]  Bump the github-actions group with 2 updates (dart-lang/web#349)
  6031c1f  2025-02-26  Kevin Moore  Delete all deprecated members (dart-lang/web#347)
  5a39fdc  2025-02-26  Kevin Moore  Merge tag 'web-v1.1.1'
  222164b  2025-02-26  Kevin Moore  Deprecate a few more things before we launch v2 (dart-lang/web#348)
  b90b63d  2025-02-25  Kevin Moore  Update APIs and docs (dart-lang/web#345)
  5caa92e  2025-02-25  Srujan Gaddam  Add catch and finally to bannedNames (dart-lang/web#346)
  e2f9741  2025-02-25  Olzhas Suleimen  Add variadic arguments (dart-lang/web#343)

webdriver (https://github.com/google/webdriver.dart/compare/b4fd859..f52afbf):
  f52afbf  2025-03-06  Parker Lougheed  Utilize switch expressions (google/webdriver.dart#327)
  ee311e0  2025-03-02  dependabot[bot]  Bump dart-lang/setup-dart from 1.7.0 to 1.7.1 (google/webdriver.dart#328)
  b0cb6a9  2025-02-27  Kevin Moore  Update to Dart/Flutter team lints and fix (google/webdriver.dart#322)
  d080ebf  2025-02-27  Kevin Moore  Update a number of APIs to return Uint8List (google/webdriver.dart#323)
  0400c06  2025-02-27  Kevin Moore  Re-enable Firefox on CI (google/webdriver.dart#324)
  38a6646  2025-02-24  Parker Lougheed  Minor cleanup for new and future lints (google/webdriver.dart#321)

Change-Id: Ied703b048f85dd78e30084ffa8bffcaab5bab67b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414301
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:intl4x type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants