Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elements. Remove 'element' from ModelElement #3990

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

keertip
Copy link
Collaborator

@keertip keertip commented Feb 6, 2025

Migrate to Element2

  • remove 'element' from ModelElement/Warnable
  • lib/src/model/accessor.dart
  • lib/src/model/field.dart
  • lib/src/model/extension_type.dart
  • test/end2end/model_test.dart

Was looking to also rename element2 to element, but this was not possible as it there are some local variables also named element. Hence the renames in the PR, but this is still not the whole set. Will do the rename in a later PR.

Verified

This commit was signed with the committer’s verified signature.
etan-status Etan Kissling
@keertip keertip requested a review from srawlins February 6, 2025 19:42
Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@keertip keertip merged commit 75d1fd7 into dart-lang:main Feb 6, 2025
9 checks passed
@keertip keertip deleted the migrateModel branch February 6, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants