Fix bug where outputs of outputs wouldn't get deleted #3879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Health |
|
Hmm, a previous regression test is failing here for another scenario. Not sure I will have the time to continue diagnosing this soon, so @davidmorgan if you want to pick it up from here that might be good. Otherwise, I can come back to it again when I have some free time at the end of a day. |
|
The timeouts on Windows should be addressed now #3880 is that the failure you meant? Thanks. |
There is a different test which is testing something related to failed actions, and the transitive outputs of those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3875
This turned out to be a tricky one to track down, basically we wouldn't even attempt to re-run any asset whose primary inputs didn't exist - but we might actually need to re-run them just to reset their state to deleted.
Updated the
_runForInputfunction to work when the primary input does not exist, and just skip the actual build step.This could probably be refactored to avoid a bunch of the unnecessary work in
_runForInput, and just more eagerly delete all the transitive primary outputs once we decide to not output a file, but this seemed like the easiest fix for now.