Refactor BuildCacheReader to BuildCacheAssetPathProvider.
#3874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. |
davidmorgan
force-pushed
the
really-copy-with-build-cache
branch
from
36ff8c0 to
a98f5bc
Compare
davidmorgan
changed the title
BuildCacheReader to BuildCacheAssetPathProvider.
davidmorgan
force-pushed
the
really-copy-with-build-cache
branch
6 times, most recently
from
bf2326e to
36da3e4
Compare
davidmorgan
force-pushed
the
really-copy-with-build-cache
branch
from
36da3e4 to
ab85648
Compare
|
Looked into the Windows failures but unable to repro so far, will kick off another run. |
jensjoha
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #3811.
Move handling of generated asset paths into the base
Reader.Disable
BatchReader/BatchWriterfor now, write caching should go next toFilesystem, that's easier to redo after the refactor.