Skip to content
This repository has been archived by the owner on May 31, 2021. It is now read-only.

migrate template defaults to use package:pedantic for lints #594

Merged
merged 8 commits into from
Jan 22, 2019
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions lib/src/generators/console_full.g.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 10 additions & 9 deletions lib/src/generators/package_simple.g.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 10 additions & 9 deletions lib/src/generators/server_shelf.g.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 14 additions & 12 deletions lib/src/generators/web_angular.g.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 9 additions & 8 deletions lib/src/generators/web_simple.g.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 9 additions & 8 deletions lib/src/generators/web_stagexl.g.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 11 additions & 11 deletions templates/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
# Defines a default set of lint rules enforced for
# projects at Google. For details and rationale,
# see: https://github.com/dart-lang/pedantic#enabled-lints.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see: -> see

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks!

include: package:pedantic/analysis_options.yaml

# For lint rules and documentation, see http://dart-lang.github.io/linter/lints.
# Uncomment to specify additional rules.
# linter:
# rules:
# - camel_case_types

analyzer:
# exclude:
# - path/to/excluded/files/**

# Lint rules and documentation, see http://dart-lang.github.io/linter/lints
linter:
rules:
- cancel_subscriptions
- hash_and_equals
- iterable_contains_unrelated_type
- list_remove_unrelated_type
- test_types_in_equals
- unrelated_type_equality_checks
- valid_regexps
22 changes: 11 additions & 11 deletions templates/console-full/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
# Defines a default set of lint rules enforced for
# projects at Google. For details and rationale,
# see: https://github.com/dart-lang/pedantic#enabled-lints.
include: package:pedantic/analysis_options.yaml

# For lint rules and documentation, see http://dart-lang.github.io/linter/lints.
# Uncomment to specify additional rules.
# linter:
# rules:
# - camel_case_types

analyzer:
# exclude:
# - path/to/excluded/files/**

# Lint rules and documentation, see http://dart-lang.github.io/linter/lints
linter:
rules:
- cancel_subscriptions
- hash_and_equals
- iterable_contains_unrelated_type
- list_remove_unrelated_type
- test_types_in_equals
- unrelated_type_equality_checks
- valid_regexps
1 change: 1 addition & 0 deletions templates/console-full/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,5 @@ environment:
# path: ^1.4.1

dev_dependencies:
pedantic: ^1.0.0
test: ^1.0.0
22 changes: 11 additions & 11 deletions templates/package-simple/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
# Defines a default set of lint rules enforced for
# projects at Google. For details and rationale,
# see: https://github.com/dart-lang/pedantic#enabled-lints.
include: package:pedantic/analysis_options.yaml

# For lint rules and documentation, see http://dart-lang.github.io/linter/lints.
# Uncomment to specify additional rules.
# linter:
# rules:
# - camel_case_types

analyzer:
# exclude:
# - path/to/excluded/files/**

# Lint rules and documentation, see http://dart-lang.github.io/linter/lints
linter:
rules:
- cancel_subscriptions
- hash_and_equals
- iterable_contains_unrelated_type
- list_remove_unrelated_type
- test_types_in_equals
- unrelated_type_equality_checks
- valid_regexps
1 change: 1 addition & 0 deletions templates/package-simple/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,5 @@ environment:
# path: ^1.4.1

dev_dependencies:
pedantic: ^1.0.0
test: ^1.0.0
22 changes: 11 additions & 11 deletions templates/server-shelf/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
# Defines a default set of lint rules enforced for
# projects at Google. For details and rationale,
# see: https://github.com/dart-lang/pedantic#enabled-lints.
include: package:pedantic/analysis_options.yaml

# For lint rules and documentation, see http://dart-lang.github.io/linter/lints.
# Uncomment to specify additional rules.
# linter:
# rules:
# - camel_case_types

analyzer:
# exclude:
# - path/to/excluded/files/**

# Lint rules and documentation, see http://dart-lang.github.io/linter/lints
linter:
rules:
- cancel_subscriptions
- hash_and_equals
- iterable_contains_unrelated_type
- list_remove_unrelated_type
- test_types_in_equals
- unrelated_type_equality_checks
- valid_regexps
4 changes: 2 additions & 2 deletions templates/server-shelf/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@ dependencies:
args: ^1.4.2
shelf: ^0.7.2

#dev_dependencies:
# test: ^1.0.0
dev_dependencies:
pedantic: ^1.0.0
22 changes: 11 additions & 11 deletions templates/web-angular/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,14 @@
# Defines a default set of lint rules enforced for
# projects at Google. For details and rationale,
# see: https://github.com/dart-lang/pedantic#enabled-lints.
include: package:pedantic/analysis_options.yaml

# For lint rules and documentation, see http://dart-lang.github.io/linter/lints.
# Uncomment to specify additional rules.
# linter:
# rules:
# - camel_case_types

analyzer:
exclude: [build/**]
errors:
Expand All @@ -6,14 +17,3 @@ analyzer:
# issues: https://github.com/dart-lang/angular_analyzer_plugin/issues
# plugins:
# - angular

# Lint rules and documentation, see http://dart-lang.github.io/linter/lints
linter:
rules:
- cancel_subscriptions
- hash_and_equals
- iterable_contains_unrelated_type
- list_remove_unrelated_type
- test_types_in_equals
- unrelated_type_equality_checks
- valid_regexps
1 change: 1 addition & 0 deletions templates/web-angular/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,5 @@ dev_dependencies:
build_runner: ^1.1.2
build_test: ^0.10.3
build_web_compilers: ^1.0.0
pedantic: ^1.0.0
test: ^1.5.1
22 changes: 11 additions & 11 deletions templates/web-simple/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
# Defines a default set of lint rules enforced for
# projects at Google. For details and rationale,
# see: https://github.com/dart-lang/pedantic#enabled-lints.
include: package:pedantic/analysis_options.yaml

# For lint rules and documentation, see http://dart-lang.github.io/linter/lints.
# Uncomment to specify additional rules.
# linter:
# rules:
# - camel_case_types

analyzer:
# exclude:
# - path/to/excluded/files/**

# Lint rules and documentation, see http://dart-lang.github.io/linter/lints
linter:
rules:
- cancel_subscriptions
- hash_and_equals
- iterable_contains_unrelated_type
- list_remove_unrelated_type
- test_types_in_equals
- unrelated_type_equality_checks
- valid_regexps
1 change: 1 addition & 0 deletions templates/web-simple/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,4 @@ environment:
dev_dependencies:
build_runner: ^1.1.2
build_web_compilers: ^1.0.0
pedantic: ^1.0.0
Loading