This repository was archived by the owner on Oct 17, 2024. It is now read-only.
Migrate to null safety #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the min SDK to 2.10.0-0 to get a language version of 2.10. Move dependency overrides to the master branches for the packages which support the 2.10 SDK on the master branch. Update travis to run the with the dev SDK and pass the `--enable-experiment=non-nullable` flag. Use the layout from collection.
Remove the flag from the `dartanalyzer` command and combine the lib and test analysis into a single step. Bump min SDK to the one which includes this package in the allow list.
- Add a changelog and bump the version. - Use the merged branch for `package:convert`.
The code prior to migration had an `assert` in the close to check that `_value` was non-null before `close()` is called. This check _would_ be performed by any read of `value`, but there is a very narrow window of interaction where this is changing with the migration. In the interest of having the smallest change possible during the migration, add back an assert.
jakemac53
reviewed
Aug 10, 2020
jakemac53
reviewed
Aug 10, 2020
jakemac53
approved these changes
Aug 10, 2020
Co-authored-by: Jacob MacDonald <jakemac@google.com>
kevmoo
reviewed
Aug 10, 2020
|
|
||
| Pre-release for the null safety migration of this package. | ||
|
|
||
| Note that 2.2.0 may not be the final stable null safety release version, we |
There was a problem hiding this comment.
I'm SO GLAD we're being clear here. Thanks!
CC @jakemac53
There was a problem hiding this comment.
I just copy/pasted this from Jake's changelogs. Thanks Jake!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.