Adds FIPS 180-4 512/t variants #75
Conversation
|
Any news? |
|
I need to resync and put this back up. Was blocked on another CL |
|
Updated; but I don't know how to restart the travis check. The errors look to be on their side. |
|
I totally forgot about this branch! |
|
@jtmcdole it happens) Do you have the opportunity to complete what you started? |
|
Any news? Very important for the implementation of JWT |
|
Ah - didn't know someone was depending on it for JWT
…On Sat, Oct 3, 2020 at 3:26 PM Ivan ***@***.***> wrote:
Any news? Very important for the implementation of JWT
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#75 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOVZWL53CR3U6VXU7RUFKLSI6QJ3ANCNFSM4IUSBCWA>
.
|
512/224 and 512/256 are variants specified in the FIPS 180-4 and commonly available in other packages.
|
Waiting on presubmits to run |
|
@lrhn or anyone interested in reviewing this? |
There was a problem hiding this comment.
LGTM. The comments are bad. They always were, but they still are. Just keep them as-is, and I'll take a look at all of them afterwards.
Do make the new Sha256224/Sha256256 classes extends Hash directly, make them private and type the public instances as Hash. That's what the rest of them should have done too.
|
Fyi: I do not have merge rights to this repository :) |
|
LGTM! Thanks. |
* Adds FIPS 180-4 512/t variants 512/224 and 512/256 are variants specified in the FIPS 180-4 and commonly available in other packages.
512/224 and 512/256 are variants specified in the FIPS 180-4 and
commonly available in other packages.