Skip to content
This repository was archived by the owner on Oct 17, 2024. It is now read-only.

Bump version number for re-publishing. #68

Merged
merged 5 commits into from
Aug 6, 2019

Conversation

efortuna
Copy link
Contributor

@efortuna efortuna commented Aug 6, 2019

No description provided.

@efortuna efortuna merged commit 520b538 into dart-archive:master Aug 6, 2019
@@ -1,3 +1,7 @@
## 2.1.1+1
Copy link
Contributor

@kwalrath kwalrath Aug 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be 2.1.2? I thought we discouraged + version numbers when the major number is > 0.

Otherwise, I don't think the package will be updated unless you do a pub get from scratch or a pub upgrade.

Copy link
Contributor Author

@efortuna efortuna Aug 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmmm.... I defer to pub and versioning originator @munificent (see his comment on this: #68 (review)). But don't you always not get updates unless you say pub upgrade?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonasfj would know...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, I don't think the package will be updated unless you do a pub get from scratch or a pub upgrade.

From pub perspective all version numbers are ordered. And you can list +1 in your pubspec.yaml, but people rarely do. Also if allowed +1 will be preferred afaik.

I'll move this discussion to the issue we had on discouraging / defining when to use it.

mosuem pushed a commit to dart-lang/core that referenced this pull request Oct 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

5 participants