This repository was archived by the owner on Oct 17, 2024. It is now read-only.
Remove 64 bit int constant so that dart2js can compile with crypto. #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmoo
reviewed
Jun 7, 2018
|
oops, thank you! Updated! |
kevmoo
approved these changes
Jun 7, 2018
|
2^64 bits several Exa-bytes. |
rakudrama
reviewed
Jun 7, 2018
| @@ -25,10 +26,6 @@ abstract class HashSink implements Sink<List<int>> { | |||
| /// used across invocations of [_iterate]. | |||
| final Uint32List _currentChunk; | |||
|
|
|||
| /// Messages with more than 2^64-1 bits are not supported. | |||
| /// So the maximum length in bytes is (2^64-1)/8. | |||
| static const _maxMessageLengthInBytes = 0x1fffffffffffffff; | |||
There was a problem hiding this comment.
Use 0x0003FFFFFFFFFFFF instead
The largest number of bytes for which we can count the bits portably across VM and JavaScript, i.e. (2^53-1)/8
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 15, 2024
…art-archive/crypto#51) * Remove 64 bit int constant.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change.... is so hair-brained I just can't even.....
The context is dart2js now has full JS number semantics, so it will cough on numbers that are not precisely representable as a double (generally > 2^53). I got around that by making this a BigNum, but it's pretty idiotic. I welcome alternatives. :-/