This repository was archived by the owner on Oct 17, 2024. It is now read-only.
Replace right shift with truncating divide #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #125 In JavaScript the shift operators cause numbers to be truncated to 32 bits, so the `>> 32` operation will always result in 0 on the web. This causes a problem once the length of the file hits 512MB.
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 15, 2024
Closes dart-lang/crypto#125 In JavaScript the shift operators cause numbers to be truncated to 32 bits, so the `>> 32` operation will always result in 0 on the web. This causes a problem once the length of the file hits 512MB.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes dart-lang/core#239
In JavaScript the shift operators cause numbers to be truncated to 32
bits, so the
>> 32operation will always result in 0 on the web. Thiscauses a problem once the length of the file hits 512MB.