Skip to content
This repository was archived by the owner on Oct 17, 2024. It is now read-only.

Move from pedantic to lints package #119

Merged
merged 1 commit into from
Jul 22, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
## 3.0.2-dev

## 3.0.1

* Fix doc links in README.
Expand Down
2 changes: 1 addition & 1 deletion analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
include: package:pedantic/analysis_options.1.9.0.yaml
include: package:lints/recommended.yaml
linter:
rules:
- avoid_empty_else
Expand Down
4 changes: 2 additions & 2 deletions lib/src/hash.dart
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ abstract class Hash extends Converter<List<int>, Digest> {
const Hash();

@override
Digest convert(List<int> data) {
Digest convert(List<int> input) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! This is a great lint!

var innerSink = DigestSink();
var outerSink = startChunkedConversion(innerSink);
outerSink.add(data);
outerSink.add(input);
outerSink.close();
return innerSink.value;
}
Expand Down
4 changes: 2 additions & 2 deletions lib/src/hmac.dart
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,10 @@ class Hmac extends Converter<List<int>, Digest> {
}

@override
Digest convert(List<int> data) {
Digest convert(List<int> input) {
var innerSink = DigestSink();
var outerSink = startChunkedConversion(innerSink);
outerSink.add(data);
outerSink.add(input);
outerSink.close();
return innerSink.value;
}
Expand Down
4 changes: 2 additions & 2 deletions pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: crypto
version: 3.0.1
version: 3.0.2-dev
description: Implementations of SHA, MD5, and HMAC cryptographic functions
repository: https://github.com/dart-lang/crypto

Expand All @@ -11,5 +11,5 @@ dependencies:
typed_data: ^1.3.0

dev_dependencies:
pedantic: ^1.10.0
lints: ^1.0.0
test: ^1.16.0