This repository was archived by the owner on Oct 17, 2024. It is now read-only.
Major version increment. #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removes deprecated members, * Makes implementation classes private (they're not needed by end-users which just need a single instance). * Makes all the hash object constants. Tests run without change, so the removed functionality was *never tested*.
|
(As usual, a major version increment of a transitive dependency of |
kevmoo
reviewed
Nov 12, 2020
pubspec.yaml
Outdated
| typed_data: ^1.3.0-nullsafety | ||
|
|
||
| dev_dependencies: | ||
| pedantic: ^1.10.0-nullsafety | ||
| test: ^1.16.0-nullsafety | ||
|
|
||
| dependency_overrides: | ||
| analyzer: |
There was a problem hiding this comment.
you should be able to get rid of all of these...right?
Or at least use pub overrides and not git overrides
There was a problem hiding this comment.
+1 on using pub overrides
natebosch
reviewed
Nov 12, 2020
pubspec.yaml
Outdated
| typed_data: ^1.3.0-nullsafety | ||
|
|
||
| dev_dependencies: | ||
| pedantic: ^1.10.0-nullsafety | ||
| test: ^1.16.0-nullsafety | ||
|
|
||
| dependency_overrides: | ||
| analyzer: |
There was a problem hiding this comment.
+1 on using pub overrides
|
Now uses pub overrides where available. Still needs an override for non-dev dependency |
* Removes deprecated members, * Makes implementation classes private (they're not needed by end-users which just need a single instance). * Makes all the hash object constants. Tests run without change, so the removed functionality was *never tested*.
Only override dev-dependencies. THIS DOES NOT WORK. The analyzer requires convert 2.0.0.
Still depend on convert override.
Co-authored-by: Nate Bosch <nbosch@google.com>
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 15, 2024
* Major version increment. * Removes deprecated members, * Makes implementation classes private (they're not needed by end-users which just need a single instance). * Makes all the hash object constants.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by end-users which just need a single instance).
Tests run without change, so the removed functionality was never tested.
WDYT?