Skip to content

Commit

Permalink
MAINT: PR 839 revisions
Browse files Browse the repository at this point in the history
* the testsuite now always uses `DarshanReport` with a context
manager to avoid shenanigans with `__del__` and garbage
collection/`pytest`/multiple threads

* this appears to fix the problem with testsuite hangs
described in gh-839 and gh-851
  • Loading branch information
tylerjereddy committed Nov 30, 2022
1 parent b2e8218 commit 2419408
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions darshan-util/pydarshan/darshan/tests/test_summary.py
Original file line number Diff line number Diff line change
Expand Up @@ -236,11 +236,11 @@ def test_main_all_logs_repo_files(tmpdir, log_filepath):
else:
assert actual_runtime_heatmap_titles == 0

# check for presence of bandwidth summary strings
# (more detailed per-module probes are present
# in test_derived_metrics_bytes_and_bandwidth())
assert "I/O performance estimate" in report_str
assert "color: blue" in report_str
# check for presence of bandwidth summary strings
# (more detailed per-module probes are present
# in test_derived_metrics_bytes_and_bandwidth())
assert "I/O performance estimate" in report_str
assert "color: blue" in report_str


class TestReportData:
Expand Down

0 comments on commit 2419408

Please sign in to comment.