Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sony ILCE-1M2 color matrix #775

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Conversation

kmilos
Copy link
Collaborator

@kmilos kmilos commented Feb 13, 2025

Changed in ADC 17.2 since #768

@LebedevRI
Copy link
Member

I don't recall what's our stance on updating these things, since it breaks all the image edits downstream?
That we are free to do such updates, and consumers should cache the color matrix used?

@kmilos
Copy link
Collaborator Author

kmilos commented Feb 13, 2025

consumers should cache the color matrix used?

I think this is the case, so existing edits are preserved and only newly imported ones are affected, right? @TurboGit @jenshannoschwalm

@LebedevRI
Copy link
Member

I mean more generally, since dt isn't, perhaps, the only user.

@LebedevRI
Copy link
Member

Looks like we've updated color matrix at least once before: #379
So i'm just going to pretend that it is fine to do.

@LebedevRI LebedevRI merged commit 5089f68 into develop Feb 13, 2025
37 of 47 checks passed
@kmilos
Copy link
Collaborator Author

kmilos commented Feb 13, 2025

So i'm just going to pretend that it is fine to do.

Thanks, that's sensible, especially given that it didn't end up on stable branch and only dt 5.0 is using it so far most likely.

@kmilos kmilos deleted the kmilos-sony-1m2-update branch February 13, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done, not propagated to stable
Development

Successfully merging this pull request may close these issues.

2 participants