feat: make fail() virtual
#48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Discussion: Old, closed PR: |
|
Thanks! can you please rebase on master and then add some unit tests to the new file in |
Making `fail()` virtual allows us to easily plug in other frameworks. This can be useful if we want to change the behavior for an `assert(False)` statement, which would allow us to easily adapt a given test-setup for use with Echidna or the SMTChecker for formal verification.
|
Ok. Not sure what kind of test case I should add here, so just added an override to |
bowd
added a commit
to bowd/ds-test
that referenced
this pull request
May 18, 2023
dapphub#48 marked the fail function as virtual but this isn't supported in Solidity 0.5
This was referenced May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making
fail()virtual allows us to easily plug in other frameworks. This can be useful if we want to change the behavior for anassert(false)statement, which would allow us to easily adapt a given test-setup for use with Echidna or the SMTChecker for formal verification.